Skip to content

fix(pubsub): make Publisher::builder() generic#4929

Merged
suzmue merged 1 commit intogoogleapis:mainfrom
suzmue:impl
Mar 6, 2026
Merged

fix(pubsub): make Publisher::builder() generic#4929
suzmue merged 1 commit intogoogleapis:mainfrom
suzmue:impl

Conversation

@suzmue
Copy link
Copy Markdown
Collaborator

@suzmue suzmue commented Mar 6, 2026

Fix the function signature for consistency with the rest of google-cloud-rust.

@suzmue suzmue requested a review from a team as a code owner March 6, 2026 22:43
@product-auto-label product-auto-label bot added the api: pubsub Issues related to the Pub/Sub API. label Mar 6, 2026
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 6, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.10%. Comparing base (11991c1) to head (0b1bf49).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4929      +/-   ##
==========================================
+ Coverage   94.08%   94.10%   +0.02%     
==========================================
  Files         219      219              
  Lines        8521     8521              
==========================================
+ Hits         8017     8019       +2     
+ Misses        504      502       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@suzmue suzmue merged commit ae04dbb into googleapis:main Mar 6, 2026
35 checks passed
@suzmue suzmue deleted the impl branch March 6, 2026 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: pubsub Issues related to the Pub/Sub API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants