Skip to content

docs: Generate QuickStarts for all APIs#4889

Merged
amanda-tarafa merged 1 commit intogoogleapis:mainfrom
amanda-tarafa:override-quickstart-service
Mar 4, 2026
Merged

docs: Generate QuickStarts for all APIs#4889
amanda-tarafa merged 1 commit intogoogleapis:mainfrom
amanda-tarafa:override-quickstart-service

Conversation

@amanda-tarafa
Copy link
Copy Markdown
Collaborator

@amanda-tarafa amanda-tarafa commented Mar 4, 2026

Also overrides the package level QuickStart service in cases where the sidekick selected service has been skipped for generation in Rust, or is under a feature flag, etc.

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 4, 2026 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.55%. Comparing base (9fe2fd7) to head (f025017).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #4889   +/-   ##
=======================================
  Coverage   94.55%   94.55%           
=======================================
  Files         213      213           
  Lines        8378     8378           
=======================================
  Hits         7922     7922           
  Misses        456      456

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@amanda-tarafa amanda-tarafa force-pushed the override-quickstart-service branch from 0c52856 to 512d8d6 Compare March 4, 2026 16:36
@amanda-tarafa
Copy link
Copy Markdown
Collaborator Author

amanda-tarafa commented Mar 4, 2026

These were tested both with:

set -ev

rustup component add clippy
cargo version
rustup show active-toolchain -v

set -e

cargo check --profile=ci --workspace
cargo test --profile=ci --workspace

echo "==== DONE ===="

/workspace/.bin/sccache --show-stats

and

set -ev

# We use `--all-features` which triggers the Tonic+Prost code generation.
echo "==== Install protoc ===="
curl -fsSL --retry 5 --retry-delay 15 -o /tmp/protoc.zip https://github.com/protocolbuffers/protobuf/releases/download/v31.0/protoc-31.0-linux-x86_64.zip
sha256sum -c <(echo 24e2ed32060b7c990d5eb00d642fde04869d7f77c6d443f609353f097799dd42 /tmp/protoc.zip)
env -C /usr/local unzip -x /tmp/protoc.zip
protoc --version

rustup component add clippy
cargo version
rustup show active-toolchain -v

echo "RUSTFLAGS in test-ignored-samples: ${RUSTFLAGS:-}"
echo "RUSTDOCFLAGS in test-ignored-samples: ${RUSTDOCFLAGS:-}"

cargo test --workspace --doc --all-features

echo "==== DONE ===="

/workspace/.bin/sccache --show-stats

@amanda-tarafa amanda-tarafa mentioned this pull request Mar 4, 2026
Merged
@amanda-tarafa amanda-tarafa force-pushed the override-quickstart-service branch 2 times, most recently from 57b5fdc to 5875a90 Compare March 4, 2026 20:59
@amanda-tarafa
docs: Generate QuickStarts for all APIs
f025017 
Also:

- Overrides the package level QuickStart service in cases where the sidekick selected service has been skipped for generation in Rust, or is under a feature flag, etc.
- Removes the `veneer` property from librarian.yaml
@amanda-tarafa amanda-tarafa force-pushed the override-quickstart-service branch from 5875a90 to f025017 Compare March 4, 2026 21:16
@amanda-tarafa amanda-tarafa marked this pull request as ready for review March 4, 2026 21:45
@amanda-tarafa amanda-tarafa requested a review from a team as a code owner March 4, 2026 21:45
@amanda-tarafa
Copy link
Copy Markdown
Collaborator Author

amanda-tarafa commented Mar 4, 2026

This is ready for review. Please take a look at #4889 (comment) for how these were tested.

@amanda-tarafa amanda-tarafa merged commit e6bdaf7 into googleapis:main Mar 4, 2026
35 checks passed
@amanda-tarafa amanda-tarafa deleted the override-quickstart-service branch March 4, 2026 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@coryan coryan coryan approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@amanda-tarafa @coryan