docs(storage): add sample for storage_open_object_multiple_ranged_read#4785
Merged
vsharonlynn merged 4 commits intogoogleapis:mainfrom Feb 25, 2026
Conversation
2fd53b5 to
80baabc
Compare
joshuatants
requested changes
Feb 24, 2026
src/storage/examples/src/objects/open_object_multiple_ranged_read.rs
Outdated
Show resolved
Hide resolved
7177922 to
1e0aa29
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4785 +/- ##
=======================================
Coverage 95.01% 95.01%
=======================================
Files 204 204
Lines 7877 7877
=======================================
Hits 7484 7484
Misses 393 393 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
joshuatants
approved these changes
Feb 24, 2026
Contributor
joshuatants
left a comment
There was a problem hiding this comment.
LGTM. Waiting for @coryan for final approval.
coryan
approved these changes
Feb 24, 2026
Collaborator
coryan
left a comment
There was a problem hiding this comment.
If there is a reason why downloading 5 and 2 bytes to a file is the best approach (e.g. because that is what the examples in other languages do) then please merge as-is.
But otherwise, it seems overly complicated to create files when a simple buffer would do.
src/storage/examples/src/objects/open_object_multiple_ranged_read.rs
Outdated
Show resolved
Hide resolved
src/storage/examples/src/objects/open_object_multiple_ranged_read.rs
Outdated
Show resolved
Hide resolved
Co-authored-by: Carlos O'Ryan <coryan@google.com>
a4aab4a to
a7cfc59
Compare
a7cfc59 to
bbff7a3
Compare
coryan
approved these changes
Feb 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add one of the samples requested in #4595.