feat(gax): retry policy decorator for 429 errors#4783
Merged
coryan merged 2 commits intogoogleapis:mainfrom Feb 27, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4783 +/- ##
==========================================
+ Coverage 94.72% 94.73% +0.01%
==========================================
Files 205 206 +1
Lines 8115 8132 +17
==========================================
+ Hits 7687 7704 +17
Misses 428 428 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
a04de27 to
374f43e
Compare
374f43e to
ceffe3d
Compare
dbolduc
approved these changes
Feb 27, 2026
coryan
commented
Feb 27, 2026
Collaborator
Author
coryan
left a comment
There was a problem hiding this comment.
PTAL, I think I fixed all the problems.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Someday we will document how to use the
RetryPolicytrait in applications and add your own policies. This may become duplicative (but still convenient) at that time.Likewise, we may add a generic decorator that ignores specific HTTP status codes or gRPC status codes. But the API for that is unclear at the moment. If that happens this will still be convenient, but would duplicate some code.
At the moment, this seems like useful thing for customers to have. The most common case would be
Aip194Strict.continue_on_too_many_requests().with_.... That is a reasonable policy for services that useResourceExhaustedto signal that a rate-based quota limit has been breached.