Skip to content

feat(storage): tracing and logging#4740

Merged
coryan merged 12 commits intogoogleapis:mainfrom
coryan:impl-storage-client-request-traces
Feb 20, 2026
Merged

feat(storage): tracing and logging#4740
coryan merged 12 commits intogoogleapis:mainfrom
coryan:impl-storage-client-request-traces

Conversation

@coryan
Copy link
Copy Markdown
Collaborator

@coryan coryan commented Feb 19, 2026

This implements logging and tracing for storage. Tracing is still protected by google_cloud_unstable_tracing.

Part of the work for #3178

Blegh, the integration test fails due to missing spans. Seems safer to tolerate some failures:

Details image

This implements tracing and logging for storage. It is not a `feat` yet because
all the code is conditional on `google_cloud_unstable_tracing`.
@product-auto-label product-auto-label bot added the api: storage Issues related to the Cloud Storage API. label Feb 19, 2026
@codecov
Copy link
Copy Markdown

codecov bot commented Feb 19, 2026

Codecov Report

❌ Patch coverage is 90.90909% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 95.01%. Comparing base (822ccac) to head (86c93b1).
⚠️ Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
src/storage/src/storage/transport.rs 89.61% 8 Missing ⚠️
src/test-utils/src/test_layer.rs 75.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4740      +/-   ##
==========================================
- Coverage   95.07%   95.01%   -0.07%     
==========================================
  Files         198      199       +1     
  Lines        7601     7701     +100     
==========================================
+ Hits         7227     7317      +90     
- Misses        374      384      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@coryan coryan changed the title impl(storage): tracing and logging feat(storage): tracing and logging Feb 20, 2026
@coryan coryan marked this pull request as ready for review February 20, 2026 13:04
@coryan coryan requested a review from a team as a code owner February 20, 2026 13:04
@coryan
Copy link
Copy Markdown
Collaborator Author

coryan commented Feb 20, 2026

/FYI: @joshuatants

/cc: @westarle

Copy link
Copy Markdown
Member

@dbolduc dbolduc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

Copy link
Copy Markdown
Collaborator Author

@coryan coryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PTAL

Copy link
Copy Markdown
Contributor

@westarle westarle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks great!! I have one comment on the docs, happy to adjust them in this PR and/or iterate in the future before removing the feature flag.

A couple attributes you might want to look at (next?) from go/gcs-sdk-trace-semconv:

  1. http.response.header.x-guploader-uploadid for debugging upload issues (your idea!)
  2. gsutil.uri (or .source, .target) for bucket/object filtering.

@coryan coryan merged commit 8b5b7a1 into googleapis:main Feb 20, 2026
35 checks passed
@coryan coryan deleted the impl-storage-client-request-traces branch February 20, 2026 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: storage Issues related to the Cloud Storage API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants