feat(storage): tracing and logging#4740
Merged
coryan merged 12 commits intogoogleapis:mainfrom Feb 20, 2026
Merged
Conversation
This implements tracing and logging for storage. It is not a `feat` yet because all the code is conditional on `google_cloud_unstable_tracing`.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4740 +/- ##
==========================================
- Coverage 95.07% 95.01% -0.07%
==========================================
Files 198 199 +1
Lines 7601 7701 +100
==========================================
+ Hits 7227 7317 +90
- Misses 374 384 +10 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
Author
|
/FYI: @joshuatants /cc: @westarle |
westarle
approved these changes
Feb 20, 2026
Contributor
westarle
left a comment
There was a problem hiding this comment.
Code looks great!! I have one comment on the docs, happy to adjust them in this PR and/or iterate in the future before removing the feature flag.
A couple attributes you might want to look at (next?) from go/gcs-sdk-trace-semconv:
http.response.header.x-guploader-uploadidfor debugging upload issues (your idea!)- gsutil.uri (or .source, .target) for bucket/object filtering.
dbolduc
approved these changes
Feb 20, 2026
This was referenced Feb 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This implements logging and tracing for storage. Tracing is still protected by
google_cloud_unstable_tracing.Part of the work for #3178
Blegh, the integration test fails due to missing spans. Seems safer to tolerate some failures:
Details