feat(pubsub): define default retry policy for publisher#4711
Merged
suzmue merged 3 commits intogoogleapis:mainfrom Feb 18, 2026
Merged
feat(pubsub): define default retry policy for publisher#4711suzmue merged 3 commits intogoogleapis:mainfrom
suzmue merged 3 commits intogoogleapis:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4711 +/- ##
==========================================
+ Coverage 95.04% 95.05% +0.01%
==========================================
Files 197 198 +1
Lines 7563 7581 +18
==========================================
+ Hits 7188 7206 +18
Misses 375 375 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
coryan
approved these changes
Feb 17, 2026
This default retry policy was determined by looking at the reference docs and comparing with the Java and Go implementations. Both of these implementations include Unknown as a retryable grpc code. Go also has a special check to avoid retrying Internal errors that are invalid UTF-8. Since strings are valid UTF-8, this problem should not need to be handled in our Rust client library. For googleapis#3019
coryan
approved these changes
Feb 18, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4711 +/- ##
==========================================
+ Coverage 95.04% 95.05% +0.01%
==========================================
Files 197 198 +1
Lines 7563 7581 +18
==========================================
+ Hits 7188 7206 +18
Misses 375 375 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This default retry policy was determined by looking at the reference docs and comparing with the Java and Go implementations. Both of these implementations include Unknown as a retryable grpc code. 10 minutes was chosen as the timeout to align with the Java implementation. This should be matched with a more aggressive backoff policy.
Go also has a special check to avoid retrying Internal errors that are invalid UTF-8. Since strings are valid UTF-8, this problem should not need to be handled in our Rust client library.
For #3019