cleanup(pubsub): fix broken tests#4647
Merged
suzmue merged 1 commit intogoogleapis:mainfrom Feb 10, 2026
Merged
Conversation
dbolduc
approved these changes
Feb 10, 2026
Member
dbolduc
left a comment
There was a problem hiding this comment.
nit: PR title? maybe: cleanup(pubsub): avoid timing in test
Collaborator
Author
Yeah I had something similar to that at first but it also importantly uses the correct name for Message now so went more general. Thank you for quick review! |
Member
Oh duh. You're right. The original title was good. I somehow missed that. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4647 +/- ##
=======================================
Coverage 95.02% 95.02%
=======================================
Files 195 195
Lines 7473 7477 +4
=======================================
+ Hits 7101 7105 +4
Misses 372 372 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PR that added this test was incorrectly merged and used the stale name for Message. This also fixes a potential source of flakiness where the timer for a batch fires before the task is aborted.