Skip to content

cleanup(pubsub)!: rename PublishHandle to PublishFuture#4636

Merged
suzmue merged 1 commit intogoogleapis:mainfrom
suzmue:renamehandle
Feb 9, 2026
Merged

cleanup(pubsub)!: rename PublishHandle to PublishFuture#4636
suzmue merged 1 commit intogoogleapis:mainfrom
suzmue:renamehandle

Conversation

@suzmue
Copy link
Copy Markdown
Collaborator

@suzmue suzmue commented Feb 9, 2026

The PublishHandle doesn't have many of the properties of a handle (aborting, etc) and just implements Future. By updating the naming to be PublishFuture, the naming more accurately represents the type.

Fixes #4635

@suzmue suzmue requested a review from a team as a code owner February 9, 2026 22:59
@codecov
Copy link
Copy Markdown

codecov bot commented Feb 9, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.01%. Comparing base (0900052) to head (d78a06c).
⚠️ Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4636      +/-   ##
==========================================
- Coverage   95.03%   95.01%   -0.02%     
==========================================
  Files         195      195              
  Lines        7465     7465              
==========================================
- Hits         7094     7093       -1     
- Misses        371      372       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@suzmue suzmue enabled auto-merge (squash) February 9, 2026 23:22
@suzmue suzmue merged commit 003e70e into googleapis:main Feb 9, 2026
34 checks passed
@suzmue suzmue deleted the renamehandle branch February 9, 2026 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rename PublishHandle to PublishFuture

2 participants