fix(pubsub): change error return type for publish to Arc#4620
Merged
suzmue merged 3 commits intogoogleapis:mainfrom Feb 9, 2026
Merged
fix(pubsub): change error return type for publish to Arc#4620suzmue merged 3 commits intogoogleapis:mainfrom
suzmue merged 3 commits intogoogleapis:mainfrom
Conversation
PhongChuong
approved these changes
Feb 9, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4620 +/- ##
==========================================
+ Coverage 95.01% 95.03% +0.01%
==========================================
Files 195 195
Lines 7465 7465
==========================================
+ Hits 7093 7094 +1
+ Misses 372 371 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dbolduc
approved these changes
Feb 9, 2026
Member
|
/gcbrun |
dbolduc
approved these changes
Feb 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To allow sharing the same crate::Error for multiple messages bundled in the same batch, we wrap the error in an Arc. This allows us to remove the code that wraps the originally Error in an Error::io.
The tests also needed to be updates since they were actually checking for the io error type.
Fixes #4619