feat(pubsub): implement into_stream for a Session#4590
Merged
haphungw merged 8 commits intogoogleapis:mainfrom Feb 9, 2026
Merged
feat(pubsub): implement into_stream for a Session#4590haphungw merged 8 commits intogoogleapis:mainfrom
into_stream for a Session#4590haphungw merged 8 commits intogoogleapis:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4590 +/- ##
==========================================
- Coverage 95.02% 95.01% -0.01%
==========================================
Files 195 195
Lines 7458 7464 +6
==========================================
+ Hits 7087 7092 +5
- Misses 371 372 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
b793089 to
5af3de9
Compare
into_stream for a Session
dbolduc
reviewed
Feb 6, 2026
Member
dbolduc
left a comment
There was a problem hiding this comment.
The code all looks good.
- we definitely need to exercise the new feature in our CI
- we should document the new feature
- the tests could be cleaned up a bit
c46d369 to
c1e4461
Compare
dbolduc
requested changes
Feb 6, 2026
Member
dbolduc
left a comment
There was a problem hiding this comment.
Just the docs thing, then I think we are good to go
c1e4461 to
210c498
Compare
dbolduc
approved these changes
Feb 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow
Sessionto be used as afutures::Stream. This enables the use of streaming primitives for message processing.This feature is gated behind
unstable-streamto maintain API stability.Fixes #4574