fix(pubsub): retry acks when channel closes#4575
Merged
dbolduc merged 1 commit intogoogleapis:mainfrom Feb 5, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4575 +/- ##
==========================================
+ Coverage 95.01% 95.02% +0.01%
==========================================
Files 195 195
Lines 7456 7456
==========================================
+ Hits 7084 7085 +1
+ Misses 372 371 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
coryan
approved these changes
Feb 5, 2026
Comment on lines
+35
to
+37
| subscription: String, | ||
| client_id: String, | ||
| grpc_subchannel_count: usize, |
Collaborator
There was a problem hiding this comment.
These three fields repeat in a number of places. Time to refactor to a struct?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4471
Use the at least once policies in the default leaser. The policies depend on the gRPC subchannel count, so plumb that through all the layers.
The effect is that we retry acks that fail with transport errors when a channel closes, and the application avoids frozen messages every hour or so.