cleanup(pubsub)!: remove explicit nack#4549
Merged
haphungw merged 3 commits intogoogleapis:mainfrom Feb 4, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4549 +/- ##
==========================================
- Coverage 95.02% 95.02% -0.01%
==========================================
Files 195 195
Lines 7456 7451 -5
==========================================
- Hits 7085 7080 -5
Misses 371 371 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…e handlers Simplify the pubsub subscriber API by removing the explicit `nack`` method and replacing it with an idiomatic `Drop` implementation. Update unit tests and documentation accordingly. Fixes googleapis#4514
ca87cd4 to
80006fe
Compare
This leaves out `gax`, `gaxi`, and `wkt`. All of the require changes to the generator.
Member
|
FYI: I changed the PR title to include a |
dbolduc
approved these changes
Feb 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simplify the pubsub subscriber API by removing the explicit
nackmethod and replacing it with an idiomaticDropimplementation. Update unit tests and documentation accordingly.Fixes #4514