fix(pubsub): nack messages when handler is dropped#4548
Merged
haphungw merged 2 commits intogoogleapis:mainfrom Feb 4, 2026
Merged
fix(pubsub): nack messages when handler is dropped#4548haphungw merged 2 commits intogoogleapis:mainfrom
haphungw merged 2 commits intogoogleapis:mainfrom
Conversation
Previously, if a handler went out of scope without being processed, the message would remain leased. Now, they are automatically rejected if the application fails to explicitly acknowledge or reject them. Fix googleapis#4514
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4548 +/- ##
=======================================
Coverage 95.01% 95.02%
=======================================
Files 195 195
Lines 7444 7456 +12
=======================================
+ Hits 7073 7085 +12
Misses 371 371 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dbolduc
approved these changes
Feb 4, 2026
Member
dbolduc
left a comment
There was a problem hiding this comment.
Nice, can you update the drop comment before merging?
src/pubsub/src/subscriber/handler.rs
Outdated
| } | ||
|
|
||
| impl Drop for AtLeastOnce { | ||
| /// Automatically rejects the message if it hasn't been acknowledged yet. |
Member
There was a problem hiding this comment.
nit: I think we should copy the documentation from the existing nack() here, especially if we are going to get rid of fn nack() altogether (which I think we should do).
| } | ||
| } | ||
|
|
||
| #[cfg(test)] |
dbolduc
approved these changes
Feb 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement
DropforAtLeastOnceto provide a safety netnack.Previously, if a handler went out of scope without being processed, the message would remain leased. Now, they are automatically rejected if the application fails to explicitly acknowledge or reject them.
Note: The next PR will refactor by removing the explicit
nack()in favor of this automatic behavior.Fix #4514