impl(pubsub): resume streams on transport errors#4411
Merged
dbolduc merged 1 commit intogoogleapis:mainfrom Jan 26, 2026
Merged
impl(pubsub): resume streams on transport errors#4411dbolduc merged 1 commit intogoogleapis:mainfrom
dbolduc merged 1 commit intogoogleapis:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4411 +/- ##
==========================================
- Coverage 94.98% 94.97% -0.02%
==========================================
Files 191 191
Lines 7265 7267 +2
==========================================
+ Hits 6901 6902 +1
- Misses 364 365 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
coryan
approved these changes
Jan 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4097
Resume streams that fail with transport errors.
This is maybe too conservative, as we could probably retry attempts to open a stream that fail with transient errors... but it is more generous than before. And we know
RST_STREAMerrors are a thing that surface as transport errors.We can further improve the retry policy, as I try to catch more failure modes in the wild.