cleanup(pubsub): cleanup BatchWorker loop and Publisher tests#4332
Merged
PhongChuong merged 2 commits intogoogleapis:mainfrom Jan 22, 2026
Merged
cleanup(pubsub): cleanup BatchWorker loop and Publisher tests#4332PhongChuong merged 2 commits intogoogleapis:mainfrom
PhongChuong merged 2 commits intogoogleapis:mainfrom
Conversation
dbolduc
previously approved these changes
Jan 21, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4332 +/- ##
=======================================
Coverage 94.87% 94.87%
=======================================
Files 187 187
Lines 7219 7219
=======================================
Hits 6849 6849
Misses 370 370 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
Author
|
@dbolduc , can you review/approve this PR again? I forgot to run |
dbolduc
approved these changes
Jan 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Followup to @dbolduc 's comments in #4286