docs(guide): fix broken LRO links in compute.md#4126
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
/gcbrun |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4126 +/- ##
==========================================
+ Coverage 94.78% 94.80% +0.01%
==========================================
Files 182 182
Lines 6885 6885
==========================================
+ Hits 6526 6527 +1
+ Misses 359 358 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dbolduc
left a comment
There was a problem hiding this comment.
You are totally right. Thanks for the fix.
Our markdown formatter linter is unhappy with the capitalization / order of the links though. Can you reformat?
--- a/guide/src/compute.md
+++ b/guide/src/compute.md
@@ -52,7 +52,7 @@ can list all the VMs in a project using the `list()` function of this type:
[billing enabled]: https://cloud.google.com/billing/docs/how-to/verify-billing-enabled#confirm_billing_is_enabled_on_a_project
[compute engine]: https://cloud.google.com/compute
+[compute engine client libraries]: https://cloud.google.com/compute/docs/api/libraries
+[configuring polling policies]: configuring_polling_policies.md
[google cloud project]: https://cloud.google.com/resource-manager/docs/creating-managing-projects
-[Compute Engine client libraries]: https://cloud.google.com/compute/docs/api/libraries
[working with long-running operations]: working_with_long_running_operations.md
-[configuring polling policies]: configuring_polling_policies.md|
/gcbrun |
docs(guide): fix broken LRO links in compute.md
Update links for "Working with long-running operations" and
"Configuring polling policies" to point to correct relative paths
in lro.md instead of non-existent absolute paths.