Skip to content

impl(auth): replace unmaintained rustls-pemfile with rustls-pki-types#4109

Merged
dbolduc merged 4 commits intogoogleapis:mainfrom
Bitdragon50:main
Dec 23, 2025
Merged

impl(auth): replace unmaintained rustls-pemfile with rustls-pki-types#4109
dbolduc merged 4 commits intogoogleapis:mainfrom
Bitdragon50:main

Conversation

@Bitdragon50
Copy link
Copy Markdown
Contributor

@Bitdragon50 Bitdragon50 commented Dec 20, 2025

replace unmaintained rustls-pemfile with rustls-pki-types for private key handling.
This is to resolve the RUSTSEC-2025-0134

@Bitdragon50 Bitdragon50 requested review from a team December 20, 2025 19:20
@google-cla
Copy link
Copy Markdown

google-cla bot commented Dec 20, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@Bitdragon50 Bitdragon50 changed the title impl(auth): impl(auth): replace unmaintained rustls-pemfile with rustls-pki-types Dec 21, 2025
@Bitdragon50 Bitdragon50 mentioned this pull request Dec 23, 2025
Open
4 tasks
@dbolduc
Copy link
Copy Markdown
Member

dbolduc commented Dec 23, 2025

/gcbrun

@codecov
Copy link
Copy Markdown

codecov bot commented Dec 23, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 90.90909% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 94.81%. Comparing base (d0589a4) to head (ad2f25c).
⚠️ Report is 10 commits behind head on main.

Files with missing lines Patch % Lines
src/auth/src/credentials/service_account.rs 90.90% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #4109      +/-   ##
==========================================
- Coverage   94.84%   94.81%   -0.04%     
==========================================
  Files         181      181              
  Lines        6853     6851       -2     
==========================================
- Hits         6500     6496       -4     
- Misses        353      355       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

dbolduc
dbolduc previously approved these changes Dec 23, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@dbolduc dbolduc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Thanks for the PR!

There is a barely-related doc thing we need to fix before merging though.

@dbolduc
Copy link
Copy Markdown
Member

dbolduc commented Dec 23, 2025

/gcbrun

dbolduc
dbolduc approved these changes Dec 23, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@dbolduc dbolduc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dbolduc dbolduc merged commit 76070ae into googleapis:main Dec 23, 2025
29 of 30 checks passed
@Wangnov Wangnov mentioned this pull request Dec 26, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dbolduc dbolduc dbolduc approved these changes

@PhongChuong PhongChuong PhongChuong approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Bitdragon50 @dbolduc @PhongChuong