impl(storage): open_object() works#3929
Merged
coryan merged 3 commits intogoogleapis:mainfrom Dec 1, 2025
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3929 +/- ##
==========================================
+ Coverage 95.22% 95.26% +0.04%
==========================================
Files 164 164
Lines 6214 6228 +14
==========================================
+ Hits 5917 5933 +16
+ Misses 297 295 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
93db950 to
0d0ad83
Compare
The new function works and it has an integration tests. The function is not mockable, and some constructors and additional traits will be needed to support mocking. The types are good enough to write tests, and start refactoring towards public (and stable) APIs.
9345cd9 to
fcec784
Compare
Contributor
Author
|
/FYI: @cjc25 @BenWhitehead |
Contributor
Author
|
@googleapis/rust-cloud-sdk PTAL |
PhongChuong
reviewed
Dec 1, 2025
PhongChuong
approved these changes
Dec 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The new function works and it has an integration tests. The function is not mockable, and some constructors and additional traits will be needed to support mocking. The types are good enough to write tests, and start refactoring towards public (and stable) APIs.
Fixes #3626