fix(gax-internal): no TLS config for http and IPv6#3926
Merged
coryan merged 2 commits intogoogleapis:mainfrom Nov 27, 2025
Merged
fix(gax-internal): no TLS config for http and IPv6#3926coryan merged 2 commits intogoogleapis:mainfrom
coryan merged 2 commits intogoogleapis:mainfrom
Conversation
When running storage tests the `httptest` module may pick an IPv6 address. The storage client tries to create an (unused) grpc::Client for the test endpoint, and fails because tonic rejects `http://[::]:*` addresses with TLS. I suspect a bug in tonic, because IPv4 addresses seem to work. Regardless, we need this case to work to keep the complexity of our tests low.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3926 +/- ##
==========================================
+ Coverage 95.14% 95.16% +0.02%
==========================================
Files 162 162
Lines 6116 6121 +5
==========================================
+ Hits 5819 5825 +6
+ Misses 297 296 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
PhongChuong
approved these changes
Nov 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When running storage tests the
httptestmodule may pick an IPv6 address. The storage client tries to create an (unused) grpc::Client for the test endpoint, and fails because tonic rejectshttp://[::]:*addresses with TLS.This may be explained by hyperium/tonic#279. The suggested fix is to use a different TLS implementation. Whether that is true or not, we need this case to work to keep the complexity of our tests low, and disabling TLS when using a http endpoint seems sensible anyway.
Fixes #3927