feat(pubsub): add byte threshold to publisher#3925
Merged
PhongChuong merged 7 commits intogoogleapis:mainfrom Dec 3, 2025
Merged
feat(pubsub): add byte threshold to publisher#3925PhongChuong merged 7 commits intogoogleapis:mainfrom
PhongChuong merged 7 commits intogoogleapis:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3925 +/- ##
==========================================
- Coverage 95.02% 94.01% -1.01%
==========================================
Files 161 160 -1
Lines 6049 5752 -297
==========================================
- Hits 5748 5408 -340
- Misses 301 344 +43 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dbolduc
reviewed
Nov 26, 2025
dbolduc
reviewed
Dec 3, 2025
Member
dbolduc
left a comment
There was a problem hiding this comment.
Looks good. I think the only thing that ought to change is the mock in the test_push_and_flush_batch test.
But lmk if I am misunderstanding something.
coryan
reviewed
Dec 3, 2025
Co-authored-by: Carlos O'Ryan <coryan@google.com>
Collaborator
Author
|
Thanks for the review. PTAL. |
dbolduc
approved these changes
Dec 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement byte threshold batching in Publisher. The batch size is the accumulation of the topic, messages data, ordering key and attribute length. All other fields are currently omitted in the size calculation.
Fixes: #3748