Skip to content

feat(pubsub)!: Rename PublisherFactory to Client#3905

Merged
PhongChuong merged 2 commits intogoogleapis:mainfrom
PhongChuong:clientRename
Nov 24, 2025
Merged

feat(pubsub)!: Rename PublisherFactory to Client#3905
PhongChuong merged 2 commits intogoogleapis:mainfrom
PhongChuong:clientRename

Conversation

@PhongChuong
Copy link
Copy Markdown
Collaborator

This new naming is consistent with the Publisher design: go/cloud-rust:pubsub-publisher-design

@codecov
Copy link
Copy Markdown

codecov bot commented Nov 24, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.94%. Comparing base (9a51612) to head (640b665).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3905   +/-   ##
=======================================
  Coverage   95.94%   95.94%           
=======================================
  Files         156      156           
  Lines        5991     5991           
=======================================
  Hits         5748     5748           
  Misses        243      243           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@PhongChuong PhongChuong marked this pull request as ready for review November 24, 2025 18:34
@PhongChuong PhongChuong requested a review from a team November 24, 2025 18:34
Copy link
Copy Markdown
Member

@dbolduc dbolduc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, but FWIW, I think the current names make more sense.

The client::Client does not feel like a client to me. It is something that can make clients.

If we changed Client::publisher (a noun) to something like Client::batch_publish (a verb), it might feel more like a client.

Your call on how to proceed.

@PhongChuong
Copy link
Copy Markdown
Collaborator Author

Approved, but FWIW, I think the current names make more sense.

The client::Client does not feel like a client to me. It is something that can make clients.

If we changed client::publisher (a noun) to something like client::batch_publish (a verb), it might feel more like a client.

Your call on how to proceed.

@dbolduc , noted. Thanks for the review. I'll merge this for now. We can revisit before the next release when Suzy is back.

@PhongChuong PhongChuong merged commit db9eb4a into googleapis:main Nov 24, 2025
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants