feat(pubsub)!: Rename PublisherFactory to Client#3905
feat(pubsub)!: Rename PublisherFactory to Client#3905PhongChuong merged 2 commits intogoogleapis:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3905 +/- ##
=======================================
Coverage 95.94% 95.94%
=======================================
Files 156 156
Lines 5991 5991
=======================================
Hits 5748 5748
Misses 243 243 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Approved, but FWIW, I think the current names make more sense.
The client::Client does not feel like a client to me. It is something that can make clients.
If we changed Client::publisher (a noun) to something like Client::batch_publish (a verb), it might feel more like a client.
Your call on how to proceed.
@dbolduc , noted. Thanks for the review. I'll merge this for now. We can revisit before the next release when Suzy is back. |
This new naming is consistent with the Publisher design: go/cloud-rust:pubsub-publisher-design