Skip to content

feat(trace/v1): generate library#3823

Merged
dbolduc merged 1 commit intogoogleapis:mainfrom
dbolduc:feat-trace-v1-generate-library
Nov 17, 2025
Merged

feat(trace/v1): generate library#3823
dbolduc merged 1 commit intogoogleapis:mainfrom
dbolduc:feat-trace-v1-generate-library

Conversation

@dbolduc
Copy link
Copy Markdown
Member

@dbolduc dbolduc commented Nov 17, 2025

This client can list traces. The trace v2 client cannot do that. We need it.

@product-auto-label product-auto-label bot added the api: cloudtrace Issues related to the Cloud Trace API. label Nov 17, 2025
@dbolduc dbolduc marked this pull request as ready for review November 17, 2025 17:14
@dbolduc dbolduc requested a review from a team November 17, 2025 17:14
@codecov
Copy link
Copy Markdown

codecov bot commented Nov 17, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.20%. Comparing base (f32408a) to head (0eb0880).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3823      +/-   ##
==========================================
+ Coverage   96.18%   96.20%   +0.01%     
==========================================
  Files         149      149              
  Lines        5767     5767              
==========================================
+ Hits         5547     5548       +1     
+ Misses        220      219       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Collaborator

@coryan coryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider the title overrides, otherwise LGTM.

@dbolduc dbolduc merged commit 8334a28 into googleapis:main Nov 17, 2025
28 checks passed
@dbolduc dbolduc deleted the feat-trace-v1-generate-library branch November 17, 2025 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: cloudtrace Issues related to the Cloud Trace API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants