feat(auth): make idtoken stable#3821
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3821 +/- ##
==========================================
+ Coverage 95.03% 95.04% +0.01%
==========================================
Files 161 161
Lines 6097 6097
==========================================
+ Hits 5794 5795 +1
+ Misses 303 302 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
coryan
left a comment
There was a problem hiding this comment.
A number of nits and questions.
alvarowolfx
left a comment
There was a problem hiding this comment.
addressed some of the comments
coryan
left a comment
There was a problem hiding this comment.
You can merge as-is. Some small cleanups you may want to do before.
|
|
||
| unstable_flags = join(" ", [ | ||
| "--cfg google_cloud_unstable_tracing", | ||
| "--cfg google_cloud_unstable_id_token", |
There was a problem hiding this comment.
Remember to update the triggers (terraform apply) after merging these changes.
| //! let audience = "https://my-service.a.run.app"; | ||
| //! let verifier = idtoken::verifier::Builder::new([audience]).build(); |
There was a problem hiding this comment.
It seems like this test executes some non-trivial code, please merge and (if needed) clean up afterwards .
| //! # use google_cloud_auth::credentials::idtoken; | ||
| //! # use google_cloud_auth::credentials::idtoken::verifier::Verifier; | ||
| //! # use std::time::Duration; | ||
| //! # tokio_test::block_on(async { |
There was a problem hiding this comment.
Ditto. Please fix (if needed) afterwards.
Towards #3449