cleanup(auth): make jsonwebtoken a dep only with cfg_google_cloud_unstable_id_token#3786
Merged
alvarowolfx merged 1 commit intogoogleapis:mainfrom Nov 13, 2025
Merged
Conversation
coryan
approved these changes
Nov 13, 2025
Collaborator
coryan
left a comment
There was a problem hiding this comment.
I am not sure I would call this "ci", maybe "cleanup"? no biggie either way.
Collaborator
Author
I was on a fence here, went back and forth on ci and cleanup. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3786 +/- ##
==========================================
- Coverage 96.23% 96.22% -0.02%
==========================================
Files 146 146
Lines 5638 5638
==========================================
- Hits 5426 5425 -1
- Misses 212 213 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Towards #3776