fix(storage): ReadObject cloneable without cloneable stub#3780
Merged
dbolduc merged 1 commit intogoogleapis:mainfrom Nov 13, 2025
mincrmatt12:fix/readobject-trait-bound
Merged
fix(storage): ReadObject cloneable without cloneable stub#3780dbolduc merged 1 commit intogoogleapis:mainfrom mincrmatt12:fix/readobject-trait-bound
ReadObject cloneable without cloneable stub#3780dbolduc merged 1 commit intogoogleapis:mainfrom
mincrmatt12:fix/readobject-trait-bound
Conversation
Manually implement `Clone` on `ReadObject` to avoid the automatic `S: Clone` bound that `#[derive(Clone)]` would otherwise add - the stub is held with an `Arc`, so the bound is unnecessary and restrictive.
Member
|
/gcbrun |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3780 +/- ##
==========================================
- Coverage 96.22% 96.17% -0.06%
==========================================
Files 145 145
Lines 5563 5567 +4
==========================================
+ Hits 5353 5354 +1
- Misses 210 213 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
coryan
approved these changes
Nov 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Manually implement
CloneonReadObjectto avoid the automaticS: Clonebound that#[derive(Clone)]would otherwise add - the stub is held with anArc, so the bound is unnecessary and restrictive.