feat(gax-internal): preserve tonic::Status errors#3758
Merged
coryan merged 1 commit intogoogleapis:mainfrom Nov 10, 2025
Merged
feat(gax-internal): preserve tonic::Status errors#3758coryan merged 1 commit intogoogleapis:mainfrom
tonic::Status errors#3758coryan merged 1 commit intogoogleapis:mainfrom
Conversation
Keep the error as a source for the `gax::Error`.
dbolduc
approved these changes
Nov 10, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3758 +/- ##
=======================================
Coverage 96.11% 96.11%
=======================================
Files 139 139
Lines 5407 5407
=======================================
Hits 5197 5197
Misses 210 210 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Keep the error as a source for the
gax::Error.Part of the work for #3626