fix(storage): send_buffered() fails for some object sizes#3616
Merged
coryan merged 2 commits intogoogleapis:mainfrom Oct 22, 2025
Merged
fix(storage): send_buffered() fails for some object sizes#3616coryan merged 2 commits intogoogleapis:mainfrom
send_buffered() fails for some object sizes#3616coryan merged 2 commits intogoogleapis:mainfrom
Conversation
If the upload size is unknown and the stream is closed at a multiple of the buffer size the client library needs to send a final `PUT` request without a payload. The `Content-Range` header was not formatted correctly in this case.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3616 +/- ##
==========================================
+ Coverage 95.98% 96.00% +0.01%
==========================================
Files 125 125
Lines 5027 5027
==========================================
+ Hits 4825 4826 +1
+ Misses 202 201 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dbolduc
reviewed
Oct 22, 2025
Member
dbolduc
left a comment
There was a problem hiding this comment.
The fix is good, but the PR needs some clean ups.
dbolduc
approved these changes
Oct 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the upload size is unknown and the stream is closed at a multiple of the buffer size the client library needs to send a final
PUTrequest without a payload. TheContent-Rangeheader was not formatted correctly in this case.Fixes #3608