Skip to content

fix(storage): disable default decompression#3550

Merged
coryan merged 4 commits intogoogleapis:mainfrom
coryan:fix-storage-disable-decompression-by-default
Oct 17, 2025
Merged

fix(storage): disable default decompression#3550
coryan merged 4 commits intogoogleapis:mainfrom
coryan:fix-storage-disable-decompression-by-default

Conversation

@coryan
Copy link
Copy Markdown
Collaborator

@coryan coryan commented Oct 16, 2025

This is the behavior we want by default. We are not breaking anything because automatic decompression (also known as "decompressive transcoding" is currently broken. A future PR will add an option to enable automatic decompression, at which time we will also fix the code to work with it.

Part of the work for #2051 and #3511

This is the behavior we want by default. We are not breaking anything because
automatic decompression (also known as "decompressive transcoding" is currently
broken. A future PR will add an option to enable automatic decompression, at
which time we will also fix the code to work with it.
@product-auto-label product-auto-label bot added the api: storage Issues related to the Cloud Storage API. label Oct 16, 2025
@codecov
Copy link
Copy Markdown

codecov bot commented Oct 16, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.70%. Comparing base (c733399) to head (b9244e3).
⚠️ Report is 8 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3550      +/-   ##
==========================================
+ Coverage   95.65%   95.70%   +0.04%     
==========================================
  Files         123      124       +1     
  Lines        4904     4935      +31     
==========================================
+ Hits         4691     4723      +32     
+ Misses        213      212       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@coryan coryan marked this pull request as ready for review October 16, 2025 18:29
@coryan coryan requested a review from a team October 16, 2025 18:29
dbolduc
dbolduc previously approved these changes Oct 17, 2025
Copy link
Copy Markdown
Collaborator Author

@coryan coryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PTAL

@coryan coryan enabled auto-merge (squash) October 17, 2025 15:08
@coryan coryan merged commit f6df213 into googleapis:main Oct 17, 2025
27 checks passed
@coryan coryan deleted the fix-storage-disable-decompression-by-default branch October 17, 2025 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: storage Issues related to the Cloud Storage API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants