fix(auth): Read scope from impersonated json#3495
Merged
sai-sunder-s merged 2 commits intogoogleapis:mainfrom Oct 10, 2025
Merged
fix(auth): Read scope from impersonated json#3495sai-sunder-s merged 2 commits intogoogleapis:mainfrom
sai-sunder-s merged 2 commits intogoogleapis:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3495 +/- ##
=======================================
Coverage 95.84% 95.85%
=======================================
Files 120 120
Lines 4789 4800 +11
=======================================
+ Hits 4590 4601 +11
Misses 199 199 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
coryan
requested changes
Oct 10, 2025
Collaborator
coryan
left a comment
There was a problem hiding this comment.
I think it is time to refactor the code. If it looks too ugly let me know.
coryan
approved these changes
Oct 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the impersonated credential json contains a
scopefield, use that instead of resorting to default scopes.