feat(storage): accept String payload for write_object#3480
Merged
dbolduc merged 1 commit intogoogleapis:mainfrom Oct 8, 2025
Merged
feat(storage): accept String payload for write_object#3480dbolduc merged 1 commit intogoogleapis:mainfrom
dbolduc merged 1 commit intogoogleapis:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3480 +/- ##
==========================================
+ Coverage 95.87% 95.90% +0.02%
==========================================
Files 118 118
Lines 4730 4732 +2
==========================================
+ Hits 4535 4538 +3
+ Misses 195 194 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
coryan
approved these changes
Oct 8, 2025
Collaborator
There was a problem hiding this comment.
I guess one could also use
String::as_str, but fewer utterances are better for our customers.
I don't think so. I think we only accept &'static strs. But yeah, they could say bytes::Bytes::from(s).
I was just surprised String didn't work and the compiler suggestions relied on knowledge of BytesSource to be useful. 🤷
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.