fix(storage): respect locational endpoints#3445
Merged
dbolduc merged 2 commits intogoogleapis:mainfrom Oct 6, 2025
Merged
Conversation
72e1562 to
90c350f
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3445 +/- ##
=======================================
Coverage 95.75% 95.75%
=======================================
Files 117 117
Lines 4662 4665 +3
=======================================
+ Hits 4464 4467 +3
Misses 198 198 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
coryan
previously approved these changes
Oct 3, 2025
90c350f to
251499a
Compare
coryan
approved these changes
Oct 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3375
Use locational endpoints as the
:authorityfield in gRPC requests, instead of the default. An analog to #3402, but for gRPC.I couldn't reproduce this with GCS. I think it was forgiving of trying to access locational resources from a global endpoint. And I did not want to restrict global endpoint usage in our test project.
I tested locally with
aiplatform, and saw the same behavior we see over HTTP. dbolduc@381b5fe