-
Notifications
You must be signed in to change notification settings - Fork 102
Closed
Labels
priority: p3Desirable enhancement or fix. May not be included in next release.Desirable enhancement or fix. May not be included in next release.type: feature request‘Nice-to-have’ improvement, new feature or different behavior or design.‘Nice-to-have’ improvement, new feature or different behavior or design.
Description
The generated code for gRPC-based clients has a lot of code that does not depend on the specific service: the generated client creates auth headers, implements the retry loop, adds the telemetry headers, etc.
We should refactor this code to google-cloud-gax-internal, where it can be reused and tested.
- Need to convert
tonic::Statuserrors to our types - Need to implement retry loop
- Need to implement timeouts per RPC
- Need to set
idempotencyfrom the generated code -
grpc::Clientshould usegax::Response - Need to change the generated code to use this client
- Support user agent over gRPC #1881
Metadata
Metadata
Assignees
Labels
priority: p3Desirable enhancement or fix. May not be included in next release.Desirable enhancement or fix. May not be included in next release.type: feature request‘Nice-to-have’ improvement, new feature or different behavior or design.‘Nice-to-have’ improvement, new feature or different behavior or design.