Skip to content

Cleanup client tests with method to create minimal table resource#7802

Merged
tswast merged 2 commits intogoogleapis:masterfrom
tswast:bq-make_table_resource
Apr 25, 2019
Merged

Cleanup client tests with method to create minimal table resource#7802
tswast merged 2 commits intogoogleapis:masterfrom
tswast:bq-make_table_resource

Conversation

@tswast
Copy link
Copy Markdown
Contributor

@tswast tswast commented Apr 24, 2019

This removes a lot of repeated code that wasn't relevant to the actual tests.

tswast added 2 commits April 24, 2019 15:49
This removes a lot of repeated code that wasn't relevant to the actual
tests.
@tswast tswast added testing api: bigquery Issues related to the BigQuery API. type: cleanup An internal cleanup or hygiene concern. labels Apr 24, 2019
@tswast tswast requested review from a team and plamut April 24, 2019 23:03
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 24, 2019
@lbristol88
Copy link
Copy Markdown
Contributor

LGTM!

@tswast tswast merged commit 8b18324 into googleapis:master Apr 25, 2019
@tswast tswast deleted the bq-make_table_resource branch April 25, 2019 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigquery Issues related to the BigQuery API. cla: yes This human has signed the Contributor License Agreement. testing type: cleanup An internal cleanup or hygiene concern.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants