Skip to content

Update Natural Language service name#7624

Merged
crwilcox merged 4 commits into
googleapis:masterfrom
mik-laj:patch-1
Jul 1, 2019
Merged

Update Natural Language service name#7624
crwilcox merged 4 commits into
googleapis:masterfrom
mik-laj:patch-1

Conversation

@mik-laj

@mik-laj mik-laj commented Mar 30, 2019

Copy link
Copy Markdown
Contributor

Hello,
It is recommended to use the full name of the service.
Greetings,
Kamil

Reference: apache/airflow#4980 (comment)
CC: @wwlian

@mik-laj mik-laj requested a review from crwilcox as a code owner March 30, 2019 14:20
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 30, 2019
@tseaver

tseaver commented Apr 1, 2019

Copy link
Copy Markdown
Contributor

@mik-laj Thanks for the patch! We've had several push-and-pulls in how API branding is done, and so I'm relctant to just merge it.

@sduskis Can you comment, or merge if this looks good to you?

@crwilcox

crwilcox commented Apr 1, 2019

Copy link
Copy Markdown
Contributor

I am also hesitant about this. We are pretty consistent in calling this language. Though, it isn't a big deal. In the readme for language (where go from this) we refer to it as Python Client for Google Cloud Natural Language

Also, should we sort this index? It is close to sorted now :)

@busunkim96

Copy link
Copy Markdown
Contributor

"Natural Language" is what the product documentation uses. https://cloud.google.com/natural-language/

@yoshi-automation yoshi-automation added the 🚨 This issue needs some love. label Apr 6, 2019
@sduskis sduskis requested a review from busunkim96 as a code owner July 1, 2019 18:46
@sduskis

sduskis commented Jul 1, 2019

Copy link
Copy Markdown
Contributor

@beccasaurus, do you have any input on this change?

@beccasaurus

Copy link
Copy Markdown
Contributor

Wherever the product name is used, I would expect it to be "Natural Language" or "Natural Language API".

"Language" is OK when referring to a service object / namespace / something in the client library which is named Language.

@crwilcox crwilcox merged commit 536c39c into googleapis:master Jul 1, 2019
@tseaver

tseaver commented Jul 1, 2019

Copy link
Copy Markdown
Contributor

@crwilcox, @sduskis It worked out OK this time, but the full CI was not run on this PR, because @mik-laj is not a team member.

@mik-laj

mik-laj commented Jul 1, 2019

Copy link
Copy Markdown
Contributor Author

@crwilcox Thanks for merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement. 🚨 This issue needs some love.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants