Skip to content

Commit 3b8ea3e

Browse files
gcf-owl-bot[bot]ohmayr
gcf-owl-bot[bot]
and
ohmayr
authored
fix: make repository and repository_id in CreateRepository required (#11749)
BEGIN_COMMIT_OVERRIDE fix: make repository and repository_id in CreateRepository required END_COMMIT_OVERRIDE - [ ] Regenerate this pull request now. PiperOrigin-RevId: 567370871 Source-Link: googleapis/googleapis@50f45da Source-Link: googleapis/googleapis-gen@a7761fe Copy-Tag: eyJwIjoicGFja2FnZXMvZ29vZ2xlLWNsb3VkLWFydGlmYWN0LXJlZ2lzdHJ5Ly5Pd2xCb3QueWFtbCIsImgiOiJhNzc2MWZlZTdhZDM1MWM0YTAxZTcyYTlkMzQ0MjJlNjc2NGI2M2ZkIn0= --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: ohmayr <omairnaveed@ymail.com>
1 parent a18915b commit 3b8ea3e

File tree

22 files changed

+77
-56
lines changed

22 files changed

+77
-56
lines changed

‎packages/google-cloud-artifact-registry/CONTRIBUTING.rst‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -143,12 +143,12 @@ Running System Tests
143143
$ nox -s system
144144

145145
# Run a single system test
146-
$ nox -s system- -- -k <name of test>
146+
$ nox -s system-3.11 -- -k <name of test>
147147

148148

149149
.. note::
150150

151-
System tests are only configured to run under Python.
151+
System tests are only configured to run under Python 3.8, 3.9, 3.10 and 3.11.
152152
For expediency, we do not run them in older versions of Python 3.
153153

154154
This alone will not run the tests. You'll need to change some local

‎packages/google-cloud-artifact-registry/google/cloud/artifactregistry/gapic_version.py‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,4 +13,4 @@
1313
# See the License for the specific language governing permissions and
1414
# limitations under the License.
1515
#
16-
__version__ = "1.8.3" # {x-release-please-version}
16+
__version__ = "0.0.0" # {x-release-please-version}

‎packages/google-cloud-artifact-registry/google/cloud/artifactregistry_v1/gapic_version.py‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,4 +13,4 @@
1313
# See the License for the specific language governing permissions and
1414
# limitations under the License.
1515
#
16-
__version__ = "1.8.3" # {x-release-please-version}
16+
__version__ = "0.0.0" # {x-release-please-version}

‎packages/google-cloud-artifact-registry/google/cloud/artifactregistry_v1/services/artifact_registry/async_client.py‎

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@
4747
from google.cloud.location import locations_pb2 # type: ignore
4848
from google.iam.v1 import iam_policy_pb2 # type: ignore
4949
from google.iam.v1 import policy_pb2 # type: ignore
50-
from google.longrunning import operations_pb2
50+
from google.longrunning import operations_pb2 # type: ignore
5151
from google.protobuf import empty_pb2 # type: ignore
5252
from google.protobuf import field_mask_pb2 # type: ignore
5353
from google.protobuf import struct_pb2 # type: ignore
@@ -1597,6 +1597,7 @@ async def sample_create_repository():
15971597
# Initialize request argument(s)
15981598
request = artifactregistry_v1.CreateRepositoryRequest(
15991599
parent="parent_value",
1600+
repository_id="repository_id_value",
16001601
)
16011602
16021603
# Make the request
@@ -1999,6 +2000,7 @@ async def sample_list_packages():
19992000
Returns:
20002001
google.cloud.artifactregistry_v1.services.artifact_registry.pagers.ListPackagesAsyncPager:
20012002
The response from listing packages.
2003+
20022004
Iterating over this object will yield
20032005
results and resolve additional pages
20042006
automatically.
@@ -2337,6 +2339,7 @@ async def sample_list_versions():
23372339
Returns:
23382340
google.cloud.artifactregistry_v1.services.artifact_registry.pagers.ListVersionsAsyncPager:
23392341
The response from listing versions.
2342+
23402343
Iterating over this object will yield
23412344
results and resolve additional pages
23422345
automatically.
@@ -2674,6 +2677,7 @@ async def sample_list_files():
26742677
Returns:
26752678
google.cloud.artifactregistry_v1.services.artifact_registry.pagers.ListFilesAsyncPager:
26762679
The response from listing files.
2680+
26772681
Iterating over this object will yield
26782682
results and resolve additional pages
26792683
automatically.
@@ -2888,6 +2892,7 @@ async def sample_list_tags():
28882892
Returns:
28892893
google.cloud.artifactregistry_v1.services.artifact_registry.pagers.ListTagsAsyncPager:
28902894
The response from listing tags.
2895+
28912896
Iterating over this object will yield
28922897
results and resolve additional pages
28932898
automatically.

‎packages/google-cloud-artifact-registry/google/cloud/artifactregistry_v1/services/artifact_registry/client.py‎

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@
5151
from google.cloud.location import locations_pb2 # type: ignore
5252
from google.iam.v1 import iam_policy_pb2 # type: ignore
5353
from google.iam.v1 import policy_pb2 # type: ignore
54-
from google.longrunning import operations_pb2
54+
from google.longrunning import operations_pb2 # type: ignore
5555
from google.protobuf import empty_pb2 # type: ignore
5656
from google.protobuf import field_mask_pb2 # type: ignore
5757
from google.protobuf import struct_pb2 # type: ignore
@@ -2070,6 +2070,7 @@ def sample_create_repository():
20702070
# Initialize request argument(s)
20712071
request = artifactregistry_v1.CreateRepositoryRequest(
20722072
parent="parent_value",
2073+
repository_id="repository_id_value",
20732074
)
20742075
20752076
# Make the request
@@ -2472,6 +2473,7 @@ def sample_list_packages():
24722473
Returns:
24732474
google.cloud.artifactregistry_v1.services.artifact_registry.pagers.ListPackagesPager:
24742475
The response from listing packages.
2476+
24752477
Iterating over this object will yield
24762478
results and resolve additional pages
24772479
automatically.
@@ -2810,6 +2812,7 @@ def sample_list_versions():
28102812
Returns:
28112813
google.cloud.artifactregistry_v1.services.artifact_registry.pagers.ListVersionsPager:
28122814
The response from listing versions.
2815+
28132816
Iterating over this object will yield
28142817
results and resolve additional pages
28152818
automatically.
@@ -3147,6 +3150,7 @@ def sample_list_files():
31473150
Returns:
31483151
google.cloud.artifactregistry_v1.services.artifact_registry.pagers.ListFilesPager:
31493152
The response from listing files.
3153+
31503154
Iterating over this object will yield
31513155
results and resolve additional pages
31523156
automatically.
@@ -3361,6 +3365,7 @@ def sample_list_tags():
33613365
Returns:
33623366
google.cloud.artifactregistry_v1.services.artifact_registry.pagers.ListTagsPager:
33633367
The response from listing tags.
3368+
33643369
Iterating over this object will yield
33653370
results and resolve additional pages
33663371
automatically.

‎packages/google-cloud-artifact-registry/google/cloud/artifactregistry_v1/services/artifact_registry/transports/rest.py‎

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,6 @@
3333
from google.auth.transport.grpc import SslCredentials # type: ignore
3434
from google.auth.transport.requests import AuthorizedSession # type: ignore
3535
from google.cloud.location import locations_pb2 # type: ignore
36-
from google.longrunning import operations_pb2
3736
from google.protobuf import json_format
3837
import grpc # type: ignore
3938
from requests import __version__ as requests_version
@@ -1334,7 +1333,9 @@ class _CreateRepository(ArtifactRegistryRestStub):
13341333
def __hash__(self):
13351334
return hash("CreateRepository")
13361335

1337-
__REQUIRED_FIELDS_DEFAULT_VALUES: Dict[str, Any] = {}
1336+
__REQUIRED_FIELDS_DEFAULT_VALUES: Dict[str, Any] = {
1337+
"repositoryId": "",
1338+
}
13381339

13391340
@classmethod
13401341
def _get_unset_required_fields(cls, message_dict):

‎packages/google-cloud-artifact-registry/google/cloud/artifactregistry_v1/types/settings.py‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,7 @@ class ProjectSettings(proto.Message):
3636
Attributes:
3737
name (str):
3838
The name of the project's settings.
39+
3940
Always of the form:
4041
4142
projects/{project-id}/projectSettings

‎packages/google-cloud-artifact-registry/google/cloud/artifactregistry_v1/types/tag.py‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,6 @@ class Tag(proto.Message):
4848
version (str):
4949
The name of the version the tag refers to,
5050
for example:
51-
5251
"projects/p1/locations/us-central1/repositories/repo1/packages/pkg1/versions/sha256:5243811"
5352
If the package or version ID parts contain
5453
slashes, the slashes are escaped.

‎packages/google-cloud-artifact-registry/google/cloud/artifactregistry_v1/types/vpcsc_config.py‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -36,9 +36,11 @@ class VPCSCConfig(proto.Message):
3636
Attributes:
3737
name (str):
3838
The name of the project's VPC SC Config.
39+
3940
Always of the form:
4041
4142
projects/{projectID}/locations/{location}/vpcscConfig
43+
4244
In update request: never set
4345
In response: always set
4446
vpcsc_policy (google.cloud.artifactregistry_v1.types.VPCSCConfig.VPCSCPolicy):

‎packages/google-cloud-artifact-registry/google/cloud/artifactregistry_v1beta2/gapic_version.py‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,4 +13,4 @@
1313
# See the License for the specific language governing permissions and
1414
# limitations under the License.
1515
#
16-
__version__ = "1.8.3" # {x-release-please-version}
16+
__version__ = "0.0.0" # {x-release-please-version}

0 commit comments

Comments
 (0)