Skip to content

Conversation

@Erliz
Copy link

@Erliz Erliz commented May 29, 2017

According to docs of translation api v2 methods translate and detect should be requested by POST http method.
This patch will fix it in translate ServiceDefinition json file

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 29, 2017
@jdpedrie jdpedrie added the api: translation Issues related to the Cloud Translation API. label May 30, 2017
@jdpedrie
Copy link
Contributor

(for reference, #287, #250)

@jdpedrie
Copy link
Contributor

Thanks for the contribution, @Erliz! I'm working to confirm this with our team. I should have more information by the end of the day.

@jdpedrie
Copy link
Contributor

Hey @Erliz, you are correct that we are now able to use the POST methods. I opened a PR at #522 which includes that change, as well as some other improvements with documentation and system tests. Since that change covers the goals of this one, I'm going to close this out.

Thanks again for bringing this back to our attention!.

@jdpedrie jdpedrie closed this May 30, 2017
@Erliz
Copy link
Author

Erliz commented May 31, 2017

I assumed that you are exporting this configuration from somewhere. Thanks for your improvement and support!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: translation Issues related to the Cloud Translation API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants