Skip to content

Fix incorrect return type in doc-comment #410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dwsupplee merged 1 commit into from
Mar 22, 2017
Merged

Fix incorrect return type in doc-comment #410

dwsupplee merged 1 commit into from
Mar 22, 2017

Conversation

@bencromwell
Copy link
Contributor

@bencromwell bencromwell commented Mar 22, 2017

Method returns a Table not a Dataset. This throws off IDEs and leads users to dive into the documentation to work out why they can't do:

        $table = $dataset->table($tableName);

        $job = $table->load(...)

@bencromwell
Fix incorrect return type in doc-comment
a5c7f1e 
Method returns a Table not a Dataset. This throws off IDEs and leads users to dive into the documentation to work out why they can't do:

```php
        $table = $dataset->table($tableName);

        $job = $table->load(...)
```
@googlebot
Copy link

googlebot commented Mar 22, 2017

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@googlebot googlebot added the cla: no This human has *not* signed the Contributor License Agreement. label Mar 22, 2017
@bencromwell
Copy link
Contributor Author

bencromwell commented Mar 22, 2017

@googlebot I signed it!

@googlebot
Copy link

googlebot commented Mar 22, 2017

CLAs look good, thanks!

@googlebot googlebot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Mar 22, 2017
@dwsupplee
Copy link
Contributor

dwsupplee commented Mar 22, 2017

Thanks for the contribution @bencromwell!

@dwsupplee dwsupplee merged commit fcc06f7 into googleapis:master Mar 22, 2017
@bencromwell bencromwell deleted the patch-1 branch March 22, 2017 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@bencromwell @googlebot @dwsupplee