-
Notifications
You must be signed in to change notification settings - Fork 451
Replace generators with an iterator class #399
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
jdpedrie
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! I'm going to pull it down and play around with it a bit more before signing off, but I don't have any requested changes in the code at the moment.
src/Storage/Bucket.php
Outdated
| * return the specified fields. | ||
| * } | ||
| * @return \Generator<Google\Cloud\Storage\StorageObject> | ||
| * @return ObjectsIterator<Google\Cloud\Storage\StorageObject> |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
src/Storage/ObjectIterator.php
Outdated
| use Google\Cloud\Core\Iterator\ItemIteratorTrait; | ||
|
|
||
| /** | ||
| * Iterates over a set of {@see Google\Cloud\Storage\Object} items. |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
jdpedrie
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
|
I'm letting travis run again against the doc changes I made in #400. |
Closes: #342
Example: