Add documentation about the expected behavior of encoding type #382
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
Contributor
|
Description looks good. Do we also want to include some documentation saying that input strings must be UTF-8 encoded? |
Contributor
Author
|
Good idea! I added in a note and the wrapper around json_encode to throw errors when we receive content that isn't correctly encoded. |
Contributor
|
LGTM |
jdpedrie
suggested changes
Mar 8, 2017
src/RequestBuilder.php
Outdated
| $uri, | ||
| ['Content-Type' => 'application/json'], | ||
| $body ? json_encode($body) : null | ||
| $body ? GuzzleHttp\json_encode($body) : null |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
7b9cb80 to
0d17761
Compare
jdpedrie
approved these changes
Mar 8, 2017
Contributor
jdpedrie
left a comment
There was a problem hiding this comment.
LGTM once CI finishes. :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/cc @michaelbausor