Skip to content

Ensure user agents are sent when using an API key #378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jdpedrie merged 1 commit into from
Mar 3, 2017
Merged

Ensure user agents are sent when using an API key #378

jdpedrie merged 1 commit into from
Mar 3, 2017

Conversation

@dwsupplee
Copy link
Contributor

@dwsupplee dwsupplee commented Mar 3, 2017 •
edited
Loading

  • Conditionally set the Authorization header, but always send user agents
  • Adds test case to cover this condition

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 3, 2017
@jdpedrie jdpedrie merged commit 66f1789 into googleapis:master Mar 3, 2017
@jdpedrie jdpedrie mentioned this pull request Mar 8, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@jdpedrie jdpedrie jdpedrie approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: core cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dwsupplee @jdpedrie @googlebot