-
Notifications
You must be signed in to change notification settings - Fork 451
Add GAPIC docs to docs site #373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| foreach ($types as &$type) { | ||
| // object is a PHPDoc keyword so it is not capable of detecting the context | ||
| // https://github.com/phpDocumentor/ReflectionDocBlock/blob/2.0.4/src/phpDocumentor/Reflection/DocBlock/Type/Collection.php#L37 | ||
| if ($type === 'Object') { |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
Cool stuff! A few notes:
|
|
Filed an issue to update those docs: googleapis/gapic-generator#1089 |
|
@michaelbausor do you know of any reference documentation for |
|
Not that I'm aware of. It is coming from here: https://github.com/grpc/grpc/blob/master/src/php/ext/grpc/call_credentials.h#L49 |
|
Docs for classes like @jdpedrie Besides the aforementioned, it looks like there are other types that are not being linked out to. |
|
@michaelbausor one more thing... Lots of links in this file that will not work on the docs site. For instance: Looks like they all just need to be prefixed with |
|
@dwsupplee updated the rest of the refs to external classes I could find (save ChannelCredentials) and regenerated the docs site on my fork. |
|
👊 |
This change adds the generated GAPIC clients to the Google Cloud PHP docs site. It takes advantage of GoogleCloudPlatform/gcloud-common#213, so we'll need to rebuild the docs site before this is merged.
docs/external-classes.jsonand transform references into external links.For an example, see https://jdpedrie.github.io/gcloud-php/#/docs/master/servicebuilder.
This closes #99.