feat: [PubSub] Annotate some resource fields with their corresponding API types#8663
Merged
Hectorhammett merged 2 commits intomainfrom Oct 20, 2025
Merged
feat: [PubSub] Annotate some resource fields with their corresponding API types#8663Hectorhammett merged 2 commits intomainfrom
Hectorhammett merged 2 commits intomainfrom
Conversation
feat: Add AwsKinesisFailureReason.ApiViolationReason feat: Add tags to Subscription, Topic, and CreateSnapshotRequest messages for use in CreateSubscription, CreateTopic, and CreateSnapshot requests respectively docs: A comment for field `received_messages` in message `.google.pubsub.v1.StreamingPullResponse` is changed PiperOrigin-RevId: 820071518 Source-Link: googleapis/googleapis@e938992 Source-Link: googleapis/googleapis-gen@825a3ca Copy-Tag: eyJwIjoiUHViU3ViLy5Pd2xCb3QueWFtbCIsImgiOiI4MjVhM2NhYTI0ZjBiZjE3MGYxYzU2ZWE1ZjJjZjczNGY4ZjlmYzUxIn0=
Hectorhammett
approved these changes
Oct 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat: Add AwsKinesisFailureReason.ApiViolationReason
feat: Add tags to Subscription, Topic, and CreateSnapshotRequest messages for use in CreateSubscription, CreateTopic, and CreateSnapshot requests respectively
docs: A comment for field
received_messagesin message.google.pubsub.v1.StreamingPullResponseis changedPiperOrigin-RevId: 820071518
Source-Link: googleapis/googleapis@e938992
Source-Link: https://github.com/googleapis/googleapis-gen/commit/825a3caa24f0bf170f1c56ea5f2cf734f8f9fc51
Copy-Tag: eyJwIjoiUHViU3ViLy5Pd2xCb3QueWFtbCIsImgiOiI4MjVhM2NhYTI0ZjBiZjE3MGYxYzU2ZWE1ZjJjZjczNGY4ZjlmYzUxIn0=