-
Notifications
You must be signed in to change notification settings - Fork 21
Closed
Labels
size: sPull request size is small.Pull request size is small.type: processA process-related concern. May include testing, release, or the like.A process-related concern. May include testing, release, or the like.
Description
Replace rimraf with native Node.js fs.promises
Description
Currently, we use rimraf in the following location:
| await rimraf(installDir); |
We should replace this dependency for the following reasons:
- Environment: These tests only run on Ubuntu, so we do not strictly need to leverage a package designed for cross-platform directory deletion.
- Security:
rimrafcurrently has a vulnerability due to its dependency onglob10.4.5.
Proposed Solution
A simpler and more secure solution is to use Node's native fs promise to delete the directory.
- Documentation: https://nodejs.org/api/fs.html#fspromisesrmdirpath-options
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
size: sPull request size is small.Pull request size is small.type: processA process-related concern. May include testing, release, or the like.A process-related concern. May include testing, release, or the like.