-
Notifications
You must be signed in to change notification settings - Fork 8
Closed
googleapis/gapic-generator-typescript
#211Labels
🚨This issue needs some love.This issue needs some love.triage meI really want to be triaged.I really want to be triaged.
Description
For irm API, annotation resource is listed in gapic-yaml, and defined in incidents.proto:
- name_pattern: projects/{project}/incidents/{incident}/annotations/{annotation}
entity_name: annotation
message Annotation {
option (google.api.resource) = {
type: "irm.googleapis.com/Annotation"
pattern: "projects/{project}/incidents/{incident}/annotations/{annotation}"
};
...
}
but we don't catch it as a path_template, now we are just looking for the resource_reference in the field of message:
const resourceReference = fieldDescriptor.options?.['.google.api.resourceReference']
while the option of message itself should be included as well, which is in messagesMap[property].options.['.google.api.resource']
Metadata
Metadata
Assignees
Labels
🚨This issue needs some love.This issue needs some love.triage meI really want to be triaged.I really want to be triaged.