Skip to content

Resource in the option of message is not included in path template #676

@xiaozhenliu-gg5

Description

@xiaozhenliu-gg5

For irm API, annotation resource is listed in gapic-yaml, and defined in incidents.proto:

  - name_pattern: projects/{project}/incidents/{incident}/annotations/{annotation}
    entity_name: annotation
message Annotation {
  option (google.api.resource) = {
    type: "irm.googleapis.com/Annotation"
    pattern: "projects/{project}/incidents/{incident}/annotations/{annotation}"
  };
...
}

but we don't catch it as a path_template, now we are just looking for the resource_reference in the field of message:

const resourceReference = fieldDescriptor.options?.['.google.api.resourceReference']

while the option of message itself should be included as well, which is in messagesMap[property].options.['.google.api.resource']

Metadata

Metadata

Labels

🚨This issue needs some love.triage meI really want to be triaged.

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions