-
Notifications
You must be signed in to change notification settings - Fork 21
Closed
googleapis/gapic-generator-typescript
#317Labels
priority: p2Moderately-important priority. Fix may not be included in next release.Moderately-important priority. Fix may not be included in next release.type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Description
We need to move all asynchronous code (promises creation) from the client constructor to the separate init method that will be called by all class methods (once, at the first request). Cloud functions don't like asynchronous stuff in constructors.
To be discussed:
- if this deferred initialization should be default, optional, or be enabled only within the cloud functions
- if we want to make all our client methods
async(possibly dropping callbacks)
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
priority: p2Moderately-important priority. Fix may not be included in next release.Moderately-important priority. Fix may not be included in next release.type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.Error or flaw in code with unintended results or allowing sub-optimal usage patterns.