Skip to content

Update deprecation warning to use sinon instead of gax.warn #614

@alicejli

Description

@alicejli

Right now, if a method or service is marked as deprecated, gax.warn is used to emit a deprecation warning. However, this inadvertently causes builds to fail, as Mocha picks up on the deprecation warnings.

Therefore, it would be prudent to replace gax.warn with a sinon stub so marking a method/service as deprecated does not break the builds.

The interim fix is to disable the deprecation warning in unit tests by setting the CI variables.

Metadata

Metadata

Assignees

Labels

priority: p2Moderately-important priority. Fix may not be included in next release.type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions