-
Notifications
You must be signed in to change notification settings - Fork 21
Closed
googleapis/gapic-generator-typescript
#926Labels
priority: p2Moderately-important priority. Fix may not be included in next release.Moderately-important priority. Fix may not be included in next release.type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Description
Using the --legacy-proto-load flag with googleads protos generates invalid JS code in service client constructors.
Below is a snippet showing the );, that causes compile errors between each this._gaxGrpc.loadProto call:
...
// Load the applicable protos.
this._protos = Object.assign(
{},
this._gaxGrpc.loadProto(
path.join(__dirname, '..', '..', 'protos'),
'google/ads/googleads/v7/enums/policy_topic_entry_type.proto')
);,
this._gaxGrpc.loadProto(
path.join(__dirname, '..', '..', 'protos'),
'google/ads/googleads/v7/enums/policy_topic_evidence_destination_mismatch_url_type.proto')
);,
...
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
priority: p2Moderately-important priority. Fix may not be included in next release.Moderately-important priority. Fix may not be included in next release.type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.Error or flaw in code with unintended results or allowing sub-optimal usage patterns.