Skip to content

Improve detect the common protos #598

@summer-ji-eng

Description

@summer-ji-eng

https://github.com/googleapis/gapic-generator-typescript/blob/64ce098c5fe8f39c932c2eb1cbee5246e3edfd99/typescript/src/schema/api.ts#L42

one presumbit fails on

--typescript-gapic_out: Cannot parse package name google.cloud: version does not match /^((v[0-9]+(p[0-9]+)?((alpha|beta)[0-9]+)?[^.]*))?$/.

Need to figure out why the package name is detected as google.cloud and not google.cloud.notebooks.v1, something maybe location BUILD.bazel miss nodejs_proto_library and nodejs_gapic_library. (need to investigate)

Metadata

Metadata

Assignees

No one assigned

    Labels

    priority: p2Moderately-important priority. Fix may not be included in next release.type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions