Skip to content

bug: wrong client name in the system test fixture for bigquery-storage #589

@tmatsuo

Description

@tmatsuo

The PR in question:

googleapis/nodejs-bigquery-storage#209

The files from owl-bot are:

https://github.com/googleapis/nodejs-bigquery-storage/blob/48e92f43ea60ee20ca6e460ec59d74b458665406/system-test/fixtures/sample/src/index.ts

and

https://github.com/googleapis/nodejs-bigquery-storage/blob/48e92f43ea60ee20ca6e460ec59d74b458665406/system-test/fixtures/sample/src/index.js

You can see both files are using BigQueryWriteClient, but this is not the correct name, so the system tests failed.

I manually changed them to BigQueryStorageClient and now the system tests is passing.

Metadata

Metadata

Assignees

Labels

priority: p2Moderately-important priority. Fix may not be included in next release.type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions