-
Notifications
You must be signed in to change notification settings - Fork 21
Closed
googleapis/gax-nodejs
#1079Labels
priority: p2Moderately-important priority. Fix may not be included in next release.Moderately-important priority. Fix may not be included in next release.type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Description
I found some errors in Safari browser (macos and ios).
This line of code throws an error "SyntaxError: Invalid regular expression: invalid group specifier name".
let segment = this.segments[index];
const variable = segment.match(/(?<={)[$0-9a-zA-Z_]+(?==.*})/g) || []; // Error line
if (segment.includes('**')) {Safari doesn't support lookbehind yet, I think this is the reason for the error.
Environment details
- OS: MacOS, iOS
- Node.js version: 12.18.2
- npm version: 6.14.5
google-gaxversion: 2.12.0
Steps to reproduce
- Open project in Safari on Mac or iOS
- Open developer console
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
priority: p2Moderately-important priority. Fix may not be included in next release.Moderately-important priority. Fix may not be included in next release.type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.Error or flaw in code with unintended results or allowing sub-optimal usage patterns.